mirror of
https://github.com/NohamR/Reclass.git
synced 2026-05-10 19:59:21 +00:00
Provider refactor: 2-method base class, ProcessProvider, ProcessPicker
Collapse Provider interface from 9 virtual methods to 2 (read + size), move providers to src/providers/, add name()/kind()/getSymbol() virtuals. Replace FileProvider with BufferProvider, add ProcessProvider (Win32) with module-based symbol resolution, wire ProcessPicker dialog, and integrate getSymbol into pointer display and command row. - Fix isReadable overflow for large addresses - Guard deferred showSourcePicker/showTypeAutocomplete against stale edits - 7/7 tests pass including 3 new provider test suites Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
sysadmin
194
src/processpicker.cpp
Normal file
194
src/processpicker.cpp
Normal file
@@ -0,0 +1,194 @@
|
||||
#include "processpicker.h"
|
||||
#include "ui_processpicker.h"
|
||||
#include <QTableWidgetItem>
|
||||
#include <QHeaderView>
|
||||
#include <QMessageBox>
|
||||
#include <QFileInfo>
|
||||
#include <QPixmap>
|
||||
|
||||
#ifdef _WIN32
|
||||
#include <windows.h>
|
||||
#include <tlhelp32.h>
|
||||
#include <psapi.h>
|
||||
#include <shellapi.h>
|
||||
#endif
|
||||
|
||||
ProcessPicker::ProcessPicker(QWidget *parent)
|
||||
: QDialog(parent)
|
||||
, ui(new Ui::ProcessPicker)
|
||||
{
|
||||
ui->setupUi(this);
|
||||
|
||||
// Configure table
|
||||
ui->processTable->setColumnWidth(0, 80); // PID column - fixed width
|
||||
ui->processTable->setColumnWidth(1, 200); // Name column - fixed width
|
||||
ui->processTable->horizontalHeader()->setStretchLastSection(true); // Path column - fills remaining space
|
||||
ui->processTable->setWordWrap(false); // Disable word wrap for single-line display
|
||||
ui->processTable->setTextElideMode(Qt::ElideLeft); // Elide from left (show end of path)
|
||||
|
||||
// Connect signals
|
||||
connect(ui->refreshButton, &QPushButton::clicked, this, &ProcessPicker::refreshProcessList);
|
||||
connect(ui->processTable, &QTableWidget::itemDoubleClicked, this, &ProcessPicker::onProcessSelected);
|
||||
connect(ui->filterEdit, &QLineEdit::textChanged, this, &ProcessPicker::filterProcesses);
|
||||
connect(ui->attachButton, &QPushButton::clicked, this, &ProcessPicker::onProcessSelected);
|
||||
|
||||
// Initial process enumeration
|
||||
refreshProcessList();
|
||||
}
|
||||
|
||||
ProcessPicker::~ProcessPicker()
|
||||
{
|
||||
delete ui;
|
||||
}
|
||||
|
||||
uint32_t ProcessPicker::selectedProcessId() const
|
||||
{
|
||||
return m_selectedPid;
|
||||
}
|
||||
|
||||
QString ProcessPicker::selectedProcessName() const
|
||||
{
|
||||
return m_selectedName;
|
||||
}
|
||||
|
||||
void ProcessPicker::refreshProcessList()
|
||||
{
|
||||
ui->processTable->clearContents();
|
||||
ui->processTable->setRowCount(0);
|
||||
m_allProcesses.clear();
|
||||
enumerateProcesses();
|
||||
}
|
||||
|
||||
void ProcessPicker::onProcessSelected()
|
||||
{
|
||||
auto* item = ui->processTable->currentItem();
|
||||
if (!item) return;
|
||||
|
||||
int row = item->row();
|
||||
m_selectedPid = ui->processTable->item(row, 0)->data(Qt::EditRole).toUInt();
|
||||
m_selectedName = ui->processTable->item(row, 1)->text();
|
||||
|
||||
accept();
|
||||
}
|
||||
|
||||
void ProcessPicker::enumerateProcesses()
|
||||
{
|
||||
QList<ProcessInfo> processes;
|
||||
|
||||
#ifdef _WIN32
|
||||
HANDLE snapshot = CreateToolhelp32Snapshot(TH32CS_SNAPPROCESS, 0);
|
||||
if (snapshot == INVALID_HANDLE_VALUE) {
|
||||
QMessageBox::warning(this, "Error", "Failed to enumerate processes.");
|
||||
return;
|
||||
}
|
||||
|
||||
PROCESSENTRY32W pe32;
|
||||
pe32.dwSize = sizeof(PROCESSENTRY32W);
|
||||
|
||||
if (Process32FirstW(snapshot, &pe32))
|
||||
{
|
||||
do
|
||||
{
|
||||
ProcessInfo info;
|
||||
info.pid = pe32.th32ProcessID;
|
||||
info.name = QString::fromWCharArray(pe32.szExeFile);
|
||||
|
||||
// Try to get full path and extract icon
|
||||
// If we can't open a process with PROCESS_QUERY_LIMITED_INFORMATION then
|
||||
// we for sure can't access their memory. - Skip in this case
|
||||
HANDLE hProcess = OpenProcess(PROCESS_QUERY_LIMITED_INFORMATION, FALSE, pe32.th32ProcessID);
|
||||
if (hProcess)
|
||||
{
|
||||
WCHAR path[MAX_PATH];
|
||||
DWORD pathLen = MAX_PATH;
|
||||
if (QueryFullProcessImageNameW(hProcess, 0, path, &pathLen) ||
|
||||
QueryFullProcessImageNameW(hProcess, PROCESS_NAME_NATIVE, path, &pathLen) ||
|
||||
GetModuleFileNameExW(hProcess, nullptr, path, pathLen))
|
||||
{
|
||||
info.path = QString::fromWCharArray(path);
|
||||
|
||||
// Extract icon from executable
|
||||
SHFILEINFOW sfi = {};
|
||||
if (SHGetFileInfoW(path, 0, &sfi, sizeof(sfi), SHGFI_ICON | SHGFI_SMALLICON)) {
|
||||
if (sfi.hIcon) {
|
||||
info.icon = QIcon(QPixmap::fromImage(QImage::fromHICON(sfi.hIcon)));
|
||||
DestroyIcon(sfi.hIcon);
|
||||
}
|
||||
}
|
||||
}
|
||||
else
|
||||
{
|
||||
info.path = "";
|
||||
}
|
||||
CloseHandle(hProcess);
|
||||
|
||||
processes.append(info);
|
||||
}
|
||||
|
||||
} while (Process32NextW(snapshot, &pe32));
|
||||
}
|
||||
|
||||
CloseHandle(snapshot);
|
||||
#else
|
||||
// Platform not supported
|
||||
QMessageBox::warning(this, "Error", "Process enumeration not supported on this platform.");
|
||||
#endif
|
||||
|
||||
m_allProcesses = processes;
|
||||
applyFilter();
|
||||
}
|
||||
|
||||
void ProcessPicker::populateTable(const QList<ProcessInfo>& processes)
|
||||
{
|
||||
ui->processTable->setRowCount(processes.size());
|
||||
|
||||
for (int i = 0; i < processes.size(); ++i) {
|
||||
const auto& proc = processes[i];
|
||||
|
||||
// PID column
|
||||
auto* pidItem = new QTableWidgetItem();
|
||||
pidItem->setData(Qt::EditRole, (int)proc.pid);
|
||||
ui->processTable->setItem(i, 0, pidItem);
|
||||
|
||||
// Name column with icon
|
||||
auto* nameItem = new QTableWidgetItem(proc.name);
|
||||
if (!proc.icon.isNull()) {
|
||||
nameItem->setIcon(proc.icon);
|
||||
}
|
||||
ui->processTable->setItem(i, 1, nameItem);
|
||||
|
||||
// Path column with tooltip for full path
|
||||
auto* pathItem = new QTableWidgetItem(proc.path);
|
||||
pathItem->setToolTip(proc.path); // Show full path on hover
|
||||
ui->processTable->setItem(i, 2, pathItem);
|
||||
}
|
||||
}
|
||||
|
||||
void ProcessPicker::filterProcesses(const QString& text)
|
||||
{
|
||||
applyFilter();
|
||||
}
|
||||
|
||||
void ProcessPicker::applyFilter()
|
||||
{
|
||||
QString filterText = ui->filterEdit->text().trimmed();
|
||||
|
||||
if (filterText.isEmpty()) {
|
||||
populateTable(m_allProcesses);
|
||||
return;
|
||||
}
|
||||
|
||||
QList<ProcessInfo> filtered;
|
||||
QString lowerFilter = filterText.toLower();
|
||||
|
||||
for (const auto& proc : m_allProcesses) {
|
||||
// Match by PID, name, or path
|
||||
if (QString::number(proc.pid).contains(lowerFilter) ||
|
||||
proc.name.toLower().contains(lowerFilter) ||
|
||||
proc.path.toLower().contains(lowerFilter)) {
|
||||
filtered.append(proc);
|
||||
}
|
||||
}
|
||||
|
||||
populateTable(filtered);
|
||||
}
|
||||
Reference in New Issue
Block a user