noham/archived-Reclass
1
0
Fork 0
mirror of https://github.com/NohamR/Reclass.git synced 2026-05-10 19:59:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Provider refactor: 2-method base class, ProcessProvider, ProcessPicker

Browse Source 
Collapse Provider interface from 9 virtual methods to 2 (read + size),
move providers to src/providers/, add name()/kind()/getSymbol() virtuals.
Replace FileProvider with BufferProvider, add ProcessProvider (Win32)
with module-based symbol resolution, wire ProcessPicker dialog, and
integrate getSymbol into pointer display and command row.

- Fix isReadable overflow for large addresses
- Guard deferred showSourcePicker/showTypeAutocomplete against stale edits
- 7/7 tests pass including 3 new provider test suites

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
sysadmin
2026-02-06 06:52:44 -07:00
parent 637aa7a550
commit 44e4d88f58
23 changed files with 1457 additions and 221 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/test_core.cpp
View File

@@ -111,13 +111,13 @@ private slots:
QCOMPARE(tree2.nodes[1].offset, 8);
}
void testFileProvider() {
void testBufferProvider() {
QByteArray data(16, '\0');
data[0] = 0x42;
data[4] = 0x10;
data[5] = 0x20;
rcx::FileProvider prov(data);
rcx::BufferProvider prov(data);
QVERIFY(prov.isValid());
QCOMPARE(prov.size(), 16);
QCOMPARE(prov.readU8(0), (uint8_t)0x42);
@@ -134,7 +134,7 @@ private slots:
void testIsReadable() {
QByteArray data(16, '\0');
rcx::FileProvider prov(data);
rcx::BufferProvider prov(data);
QVERIFY(prov.isReadable(0, 4));
QVERIFY(prov.isReadable(0, 16));
QVERIFY(!prov.isReadable(0, 17));
@@ -191,7 +191,7 @@ private slots:
void testIsReadableOverflow() {
QByteArray data(16, '\0');
rcx::FileProvider prov(data);
rcx::BufferProvider prov(data);
// Normal cases
QVERIFY(prov.isReadable(0, 16));
QVERIFY(!prov.isReadable(0, 17));
@@ -260,7 +260,7 @@ private slots:
void testProviderWrite() {
QByteArray data(16, '\0');
rcx::FileProvider prov(data);
rcx::BufferProvider prov(data);
QVERIFY(prov.isWritable());
QByteArray patch;