noham/archived-Reclass
1
0
Fork 0
mirror of https://github.com/NohamR/Reclass.git synced 2026-05-10 19:59:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: options dialog test segfault from dangling ref to themes() temporary

Browse Source
This commit is contained in:
IChooseYou
2026-02-15 13:53:59 -07:00
parent f2dab07870
commit f9b33f2ba7
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/test_options_dialog.cpp
View File

@@ -132,9 +132,8 @@ private slots:
// Verify the palette Highlight is distinguishable from Window background // Verify the palette Highlight is distinguishable from Window background
// This is the root cause of broken hover: if they're the same, hover is invisible // This is the root cause of broken hover: if they're the same, hover is invisible
auto& tm = ThemeManager::instance(); auto& tm = ThemeManager::instance();
for (int i = 0; i < tm.themes().size(); ++i) { const auto themes = tm.themes();
const auto& theme = tm.themes()[i]; for (const auto& theme : themes) {
// selection must differ from background
QVERIFY2(theme.selection != theme.background, QVERIFY2(theme.selection != theme.background,
qPrintable(QString("Theme '%1': selection == background (%2)") qPrintable(QString("Theme '%1': selection == background (%2)")
.arg(theme.name, theme.background.name()))); .arg(theme.name, theme.background.name())));