From c92b60dd87de7b1bd2936360181d152bf62fc1cb Mon Sep 17 00:00:00 2001
From: looskie <50378828+Looskie@users.noreply.github.com>
Date: Sat, 26 Jun 2021 12:52:20 -0400
Subject: [PATCH] Refactoring: Logical names + cleaner code + better status
 codes

---
 pages/api/[...id].ts | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/pages/api/[...id].ts b/pages/api/[...id].ts
index 7ada28a..ed33cd8 100644
--- a/pages/api/[...id].ts
+++ b/pages/api/[...id].ts
@@ -18,7 +18,7 @@ type Parameters = {
 };
 
 export default async function handler(req: NextApiRequest, res: NextApiResponse<Data>) {
-    let axiosRes;
+    let getUser;
     const params: Parameters = req.query,
         userId = req.query.id[0];
 
@@ -28,13 +28,13 @@ export default async function handler(req: NextApiRequest, res: NextApiResponse<
         });
 
     try {
-        axiosRes = await axios.get(`https://api.lanyard.rest/v1/users/${userId}`);
-    } catch (err) {
-        console.log(err);
+        getUser = await axios(`https://api.lanyard.rest/v1/users/${userId}`);
+    } catch (error) {
+        if (error.response.status === 404) return res.status(404).send({ error: "Invalid user!" });
 
-        if (err.response.status === 404) return res.send({ error: "Invalid user!" });
+        console.log(error); // Only console log the error if its not a 404
 
-        return res.send({
+        return res.status(400).send({
             error: `Something went wrong! If everything looks correct and this still occurs, please contact @cnraddd on Twitter.`,
         });
     }
@@ -42,6 +42,6 @@ export default async function handler(req: NextApiRequest, res: NextApiResponse<
     res.setHeader("Content-Type", "image/svg+xml; charset=utf-8");
     res.setHeader("content-security-policy", "default-src 'none'; img-src * data:; style-src 'unsafe-inline'");
 
-    let svg = await renderCard(axiosRes.data, params);
+    const svg = await renderCard(getUser.data, params);
     res.status(200).send(svg as any);
 }