chore: use unzip and zip when available

README.md

@@ -26,6 +26,8 @@ first, make sure you have [ar](https://command-not-found.com/ar) and [tar](https
 
 also obviously install python, version 3.9 or greater is required
 
+the `zip` and `unzip` commands are *optional* dependencies, they may [fix issues when extracting certain IPAs with chinese characters](https://github.com/asdfzxcvbn/pyzule-rw/wiki/file-does-not-exist-(executable)-%3F), etc
+
 <details>
 <summary><b>linux/WSL/macOS instructions</b></summary>
 <br/>

cyan/extras/Cephei.framework/Info.plist

@@ -4,24 +4,34 @@
 <dict>
 	<key>CFBundleDevelopmentRegion</key>
 	<string>English</string>
+
 	<key>CFBundleExecutable</key>
 	<string>Cephei</string>
+
 	<key>CFBundleIdentifier</key>
 	<string>ws.hbang.common</string>
+
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
+
 	<key>CFBundleName</key>
 	<string>Cephei</string>
+
 	<key>CFBundlePackageType</key>
 	<string>BNDL</string>
+
 	<key>CFBundleShortVersionString</key>
 	<string>1.0.0</string>
+
 	<key>CFBundleSignature</key>
 	<string>????</string>
+
 	<key>CFBundleVersion</key>
 	<string>1.0</string>
+
 	<key>DTPlatformName</key>
 	<string>iphoneos</string>
+
 	<key>HBPackageIdentifier</key>
 	<string>ws.hbang.common</string>
 </dict>

cyan/extras/CepheiPrefs.framework/Info.plist

@@ -4,26 +4,37 @@
 <dict>
 	<key>CFBundleDevelopmentRegion</key>
 	<string>English</string>
+
 	<key>CFBundleExecutable</key>
 	<string>CepheiPrefs</string>
+
 	<key>CFBundleIdentifier</key>
 	<string>ws.hbang.common.prefs</string>
+
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
+
 	<key>CFBundleName</key>
 	<string>Cephei</string>
+
 	<key>CFBundlePackageType</key>
 	<string>BNDL</string>
+
 	<key>CFBundleShortVersionString</key>
 	<string>1.0.0</string>
+
 	<key>CFBundleSignature</key>
 	<string>????</string>
+
 	<key>CFBundleVersion</key>
 	<string>1.0</string>
+
 	<key>DTPlatformName</key>
 	<string>iphoneos</string>
+
 	<key>HBPackageIdentifier</key>
 	<string>ws.hbang.common</string>
+
 	<key>NSPrincipalClass</key>
 	<string>HBDemoRootListController</string>
 </dict>

cyan/tbhtypes/executable.py

@@ -35,7 +35,12 @@ class Executable:
 
   def __init__(self, path: str, bundle_path: Optional[str] = None):
     if not os.path.isfile(path):
-      sys.exit(f"[!] {path} does not exist (executable)")
+      print(f"[!] {path} does not exist (executable)", file=sys.stderr)
+      sys.exit(
+        "[?] check the wiki for info: "
+        "https://github.com/asdfzxcvbn/pyzule-rw/wiki/"
+        "file-does-not-exist-(executable)-%3F"
+      )
 
     self.path = path
     self.bundle_path = bundle_path

cyan/tbhutils.py

@@ -10,6 +10,9 @@ from glob import glob, iglob
 from argparse import Namespace
 from typing import Optional, Any
 
+HAS_ZIP = shutil.which("zip") is not None
+HAS_UNZIP = shutil.which("unzip") is not None
+
 
 def validate_inputs(args: Namespace) -> Optional[str]:
   if not (
@@ -81,7 +84,15 @@ def get_app(path: str, tmpdir: str, is_ipa: bool) -> str:
         elif not any(name.endswith(".app/Info.plist") for name in names):
           sys.exit("[!] no Info.plist, invalid app")
 
-        ipa.extractall(tmpdir)
+        # using unzip fixes extraction errors in ipas with chinese chars, etc
+        if HAS_UNZIP:
+          subprocess.run(
+            ["unzip", path, "-d", tmpdir],
+            stdout=subprocess.DEVNULL
+          )
+        else:
+          ipa.extractall(tmpdir)
+
         app = glob(f"{payload}/*.app")[0]
     except (KeyError, IndexError):
       sys.exit("[!] couldn't find either Payload or app folder, invalid ipa")
@@ -180,14 +191,25 @@ def make_ipa(tmpdir: str, output: str, level: int) -> None:
   os.chdir(tmpdir)
   weird = 0
 
-  with zipfile.ZipFile(
+  if HAS_ZIP:
-      output, "w", zipfile.ZIP_DEFLATED, compresslevel=level
+    try:
-  ) as zf:
+      os.remove(output)  # zip command updates zipfiles by default
-    for f in iglob("Payload/**", recursive=True):
+    except FileNotFoundError:
-      try:
+      pass
-        zf.write(f)
+
-      except ValueError:
+    subprocess.run(
-        weird += 1
+      ["zip", f"-{level}", "-r", output, "Payload"],
+      stdout=subprocess.DEVNULL
+    )
+  else:
+    with zipfile.ZipFile(
+        output, "w", zipfile.ZIP_DEFLATED, compresslevel=level
+    ) as zf:
+      for f in iglob("Payload/**", recursive=True):
+        try:
+          zf.write(f)
+        except ValueError:
+          weird += 1
 
   if weird != 0:
     print(f"[?] was unable to zip {weird} file(s) due to timestamps")