noham/lanyard-profile-readme
1
0
Fork 0
mirror of https://github.com/NohamR/lanyard-profile-readme.git synced 2026-05-26 04:17:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactoring: Logical names + cleaner code + better status codes

Browse Source
This commit is contained in:
looskie
2021-06-26 12:52:20 -04:00
parent 1e88600daf
commit c92b60dd87
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pages/api/[...id].ts
View File

@@ -18,7 +18,7 @@ type Parameters = {
}; };
export default async function handler(req: NextApiRequest, res: NextApiResponse<Data>) { export default async function handler(req: NextApiRequest, res: NextApiResponse<Data>) {
let axiosRes; let getUser;
const params: Parameters = req.query, const params: Parameters = req.query,
userId = req.query.id[0]; userId = req.query.id[0];
@@ -28,13 +28,13 @@ export default async function handler(req: NextApiRequest, res: NextApiResponse<
}); });
try { try {
axiosRes = await axios.get(`https://api.lanyard.rest/v1/users/${userId}`); getUser = await axios(`https://api.lanyard.rest/v1/users/${userId}`);
} catch (err) { } catch (error) {
console.log(err); if (error.response.status === 404) return res.status(404).send({ error: "Invalid user!" });
if (err.response.status === 404) return res.send({ error: "Invalid user!" }); console.log(error); // Only console log the error if its not a 404
return res.send({ return res.status(400).send({
error: `Something went wrong! If everything looks correct and this still occurs, please contact @cnraddd on Twitter.`, error: `Something went wrong! If everything looks correct and this still occurs, please contact @cnraddd on Twitter.`,
}); });
} }
@@ -42,6 +42,6 @@ export default async function handler(req: NextApiRequest, res: NextApiResponse<
res.setHeader("Content-Type", "image/svg+xml; charset=utf-8"); res.setHeader("Content-Type", "image/svg+xml; charset=utf-8");
res.setHeader("content-security-policy", "default-src 'none'; img-src * data:; style-src 'unsafe-inline'"); res.setHeader("content-security-policy", "default-src 'none'; img-src * data:; style-src 'unsafe-inline'");
let svg = await renderCard(axiosRes.data, params); const svg = await renderCard(getUser.data, params);
res.status(200).send(svg as any); res.status(200).send(svg as any);
} }